Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOOKDEVX-711 Assign material to selection #2429

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

JGamache-autodesk
Copy link
Collaborator

New context op to assign the material context to the current selection.

New context op to assign the material context to the current selection.
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, simple and to the point! Just a minor comment in the test which you might want to fix.

Comment on lines 505 to 507
proxyPathSegment = mayaUtils.createUfePathSegment(proxyShape)
proxyShapePath = ufe.Path([proxyPathSegment])
proxyShapeItem = ufe.Hierarchy.createItem(proxyShapePath)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: could be just
ufeUtils.createItem(proxyShape)

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Jun 20, 2022
@JGamache-autodesk
Copy link
Collaborator Author

Only known issues in preflight. Ready for merge.

@seando-adsk seando-adsk added the ufe-usd Related to UFE-USD plugin in Maya-Usd label Jun 21, 2022
@seando-adsk seando-adsk merged commit 1eeaaa3 into dev Jun 21, 2022
@seando-adsk seando-adsk deleted the t_gamaj/LOKDEVX-711/assign_material_to_selection branch June 21, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants