MAYA-123462 usdEditAsMaya set doesn't disappear when cancelling editi… #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng as Maya Fix crash related to unsupported !invert! + remove duplicated declaration of Bool
boudrey
commented
Jun 3, 2022
| @@ -120,9 +132,11 @@ Ufe::Attribute::Ptr UsdAttributes::attribute(const std::string& name) | |||
| }; | |||
|
|
|||
| #undef ADD_UFE_USD_CTOR | |||
| auto ctorIt = ctorMap.find(newAttrType); | |||
There was a problem hiding this comment.
Avoid crash when type is not found like it was before.
boudrey
commented
Jun 3, 2022
| @@ -108,7 +121,6 @@ Ufe::Attribute::Ptr UsdAttributes::attribute(const std::string& name) | |||
| ADD_UFE_USD_CTOR(Float3), | |||
| ADD_UFE_USD_CTOR(Double3), | |||
| ADD_UFE_USD_CTOR(Generic), | |||
| ADD_UFE_USD_CTOR(Bool), | |||
There was a problem hiding this comment.
Bool was added twice.
JGamache-autodesk
previously approved these changes
Jun 6, 2022
lib/mayaUsd/ufe/UsdAttributes.cpp
Outdated
| { | ||
| PXR_NS::TfToken tok(name); | ||
| bool isInverseOp = _IsInverseOp(tok); | ||
| static size_t invertPrefixLen = strlen(invertPrefix); |
There was a problem hiding this comment.
I rather like
static constexpr size_t invertPrefixLen(sizeof(invertPrefix)/sizeof(invertPrefix[0]));
for fully const strings.
JGamache-autodesk
approved these changes
Jun 6, 2022
boudrey
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng as Maya
Fix crash related to unsupported !invert!