Fixing autotest failures that arise after enabling UFE Proxy Lights in Maya #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.assertEqual(len(mc.ls(type='directionalLight')), 1) | ||
| # Latest (2022-05-24) Maya preview release creates proxy light nodes in the scene for USD lights, | ||
| # so the query below returns 2 now. Comment out the check. | ||
| #self.assertEqual(len(mc.ls(type='directionalLight')), 1) |
There was a problem hiding this comment.
I think we should keep the check there and assert that the value is 2. That way if the behavior changes we can detect it. We'll have to add some python code to detect the Maya version and change the test based on that.
Something along the lines of :
mayaUtils.mayaMajorVersion() > 2023
should be useful.
williamkrick
approved these changes
May 24, 2022
vlasovi
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.