Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[al] Added support for importing animated bool and int type attributes #2318

Merged
merged 1 commit into from
May 2, 2022
Merged

[al] Added support for importing animated bool and int type attributes #2318

merged 1 commit into from
May 2, 2022

Conversation

csyshing
Copy link
Collaborator

We have the function DgNodeHelper::setFloatAttrAnim() for float type attributes but missing similar functions for int and bool types, this PR is for that case.

@csyshing csyshing changed the title Added support for importing animated bool and int type attributes [al] Added support for importing animated bool and int type attributes Apr 28, 2022
@csyshing csyshing added the al Related to AnimalLogic plugin label Apr 28, 2022
@seando-adsk seando-adsk requested a review from ppt-adsk April 29, 2022 14:16
ppt-adsk
ppt-adsk approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been nice to have some kind of automated test for this functionality, but I trust that you're measuring quality internally at AL in some form.

@csyshing
Copy link
Collaborator Author

csyshing commented May 1, 2022

Would have been nice to have some kind of automated test for this functionality, but I trust that you're measuring quality internally at AL in some form.

Yes, we do have unit tests on the client side that using these functions (not part of the AL_USDMaya code base).

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label May 2, 2022
@seando-adsk seando-adsk merged commit 7d2d2ab into Autodesk:dev May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppt-adsk ppt-adsk ppt-adsk approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
al Related to AnimalLogic plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csyshing @ppt-adsk @seando-adsk @ecp-maya-devops-adsk