Use USDLuxTokens for spot light #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
suggested changes
Apr 6, 2022
| @@ -134,11 +134,11 @@ class HdMayaSpotLightAdapter : public HdMayaLightAdapter | |||
| } else if (paramName == UsdLuxTokens->treatAsPoint) { | |||
| const bool treatAsPoint = (light.shadowRadius() == 0.0); | |||
| return VtValue(treatAsPoint); | |||
| } else if (paramName == HdLightTokens->shapingConeAngle) { | |||
| } else if (paramName == UsdLuxTokens->inputsShapingConeAngle) { | |||
There was a problem hiding this comment.
We would like to be able to compile MayaUsd and mtoh against older versions of USD as well. You will need to add some preprocessor macros testing #if PXR_VERSION >= 2105 before using the new tokens.
williamkrick
approved these changes
Apr 7, 2022
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly starting with Pixar USD 21.05 we should use UsdLuxTokens for spot light parameters instead of HdLightTokes
From 21.05 release notes:
"UsdLux Shadow and Shaping APIs are now connectable. All attributes on these APIs have been given the "inputs:" prefix."
In our "hdRPR" render delegate we use these "inputs" prefixes but it does not work with MtoH without such fixes.