MAYA-121277 Create usdGeomNode to extract usd geometry on compute #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonblaisautodesk
changed the title
| MayaUsd::ImportData readData; | ||
| readData.setFilename(fileName); | ||
|
|
||
| if (!rootPrim.empty()) { |
There was a problem hiding this comment.
Could mention that if unset the default is "/". Or maybe add this detail to the class comment in the header.
pierrebai-adsk
requested changes
Mar 10, 2022
pierrebai-adsk
previously approved these changes
Mar 10, 2022
simonblaisautodesk
added
ready-for-merge
simonblaisautodesk
added
the
ready-for-merge
ppt-adsk
previously approved these changes
Mar 15, 2022
ppt-adsk
removed
the
ready-for-merge
ppt-adsk
approved these changes
Mar 16, 2022
simonblaisautodesk
added
the
ready-for-merge
ppt-adsk
added
core
ppt-adsk
deleted the
t_blais/MAYA-121277/investigate-creating-usd-mesh-node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part from a long term goal to simplify the maya mesh file by embedding 'usd' or other format directly in the scene.
The performance angle is to be able to load on demand the geometry, so if the node is not visible it would not even load the file immediately. When this work we could have low res and high res version in the same Maya file without paying memory and load time cost for the high res, as long as the user work with the low res. But this pull request here simply add the possibility to prototype things further in maya.