MAYA-121808 Add curve filtering option in UI #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the existing filtering mechanism.
|
Preflight succeeded. One Linux machine had GPU issues though. |
seando-adsk
reviewed
Mar 4, 2022
Comment on lines
+691
to
+692
| // We currently have only one type to filter. In the future, we might need to build the array separately as more types are added. | ||
| $currentOptions = mayaUsdTranslatorExport_SetFromCheckbox($currentOptions, "", "filterTypes=nurbsCurve", "exportCurvesCheckBox"); |
There was a problem hiding this comment.
What you are saying here is that currently you cannot call mayaUsdTranslatorExport_SetFromCheckbox() again with a different filterType because then the option string would have two filterType args. Is that right. Instead we would need extra code here to build up the array of filter types?
There was a problem hiding this comment.
Exactly. In a future where we might add more prim filtering checkboxes, the filterType array will have to be built by reviewing all checkboxes before being assigned to the filterType export parameter.
seando-adsk
approved these changes
Mar 4, 2022
JGamache-autodesk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the existing filtering mechanism.