Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 change _GetLocalTransformForDagPoseMember check from maya api version to diffrence_type iterator trait support, since 2019's MArrayIteratorTemplate.h has missing iterator traits. #2136

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

sun-frog
Copy link
Contributor

Maya 2019 MArrayIteratorTemplate.h has missing iterator traits. This has been fix in Maya 2020 onwards.

@williamkrick williamkrick self-requested a review February 23, 2022 15:16
williamkrick
williamkrick previously approved these changes Feb 23, 2022
Copy link
Contributor

@williamkrick williamkrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sun-frog I dug into this internally and found that Maya 2019.3 doesn't have the missing iterator traits but some later patch fixes available to some enterprise customers do have the traits. The change you've proposed here will disable the code for some versions that do have support for the iterators. In this case I'm okay with disabling the code in 2019 because it is a debug sanity check to validate behavior rather than some user-visible behavior.

For completeness I'll include how to correctly detect that Maya has the required API. In FindMaya.cmake you can copy the pattern used for MAYA_UPDATE_UFE_IDENTIFIER_SUPPORT. This build code does a regular expression search for a specified string in a Maya API header file. In this case we'd need to search MArrayIteratorTemplate.h for "difference_type" and then set an new env var when it is present.

@seando-adsk seando-adsk added the build Related to building maya-usd repository label Feb 23, 2022
@sun-frog sun-frog changed the title 🐛 change maya api version check from 2019 to 2020 in _GetLocalTransformForDagPoseMember, since 2019's MArrayIteratorTemplate.h has missing iterator traits. 🐛 change _GetLocalTransformForDagPoseMember check from maya api version to diffrence_type iterator trait support, since 2019's MArrayIteratorTemplate.h has missing iterator traits. Feb 23, 2022
@williamkrick williamkrick self-requested a review February 24, 2022 14:05
williamkrick
williamkrick previously approved these changes Feb 24, 2022
@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 24, 2022
@seando-adsk
Copy link
Collaborator

@sun-frog I was about to merge your change, but there is a conflict that needs to be resolved first.

…on to diffrence_type iterator trait support, since 2019's MArrayIteratorTemplate.h has missing iterator traits.
@sun-frog sun-frog force-pushed the fix-maya-2019-compile-bug branch from f622349 to f55fdc7 Compare February 25, 2022 06:31
@seando-adsk seando-adsk merged commit 82d5728 into Autodesk:dev Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants