mayaUsdDuplicate selects duplicated object. #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Feb 16, 2022
|
|
||
| /// \class UfeSelectionUndoItem | ||
| /// \brief Record data needed to undo or redo select nodes sub-operations. | ||
| class UfeSelectionUndoItem : public OpUndoItem |
There was a problem hiding this comment.
Added a new UfeSelectionUndoItem class. Arguably the existing SelectionUndoItem should be transformed to hold a Ufe::Selection, because MSelectionList cannot hold Ufe::SceneItem's. At that point we can simply remove UfeSelectionUndoItem. This work is out of scope for this pull request.
| // - USD duplicate to Maya: no path segment to add. | ||
| Ufe::Path childPath = (fSrcPath.runTimeId() == getMayaRunTimeId()) | ||
| ? | ||
| // Maya duplicate to USD |
There was a problem hiding this comment.
Really small nit-pick, if the comment was before the '?' it would layout better.
| void UfeSelectionUndoItem::invert() | ||
| { | ||
| auto globalSn = Ufe::GlobalSelection::get(); | ||
| auto previousSelection = *globalSn; |
There was a problem hiding this comment.
Can the returned value ever be null?
There was a problem hiding this comment.
No, the UFE global selection is initialized in Maya's model class, and we assert that the result is non-null.
pierrebai-adsk
previously approved these changes
Feb 16, 2022
pierrebai-adsk
approved these changes
Feb 16, 2022
ppt-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.