Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed worldspace export flag behaviour to only bake xform at the top level prim #1931

Merged

Conversation

csyshing
Copy link
Collaborator

This PR fixed tow problems:

  • The worldspace flag for exporter to only bake xform at the top level prim, children prims xforms would be remained unchanged
  • The logic to handle selection objects has also been modified to match mayaUsdPlugin that when selecting parent node and one of the children, unselected siblings would be excluded, for example:
- parent            * selected
   - child_A       * selected
   - child_B

child _B object would be excluded when exporting.

@csyshing csyshing added the al Related to AnimalLogic plugin label Dec 19, 2021
@csyshing
Copy link
Collaborator Author

csyshing commented Dec 20, 2021

Jenkins test failed due to this one:

    ======================================================================
    FAIL: test_anonymousLayerSerialisation (testLayerManager.TestLayerManagerSerialisation)
    Tests multiple anonymous sublayers can be saved and restored.
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/S/jenkins/workspace/ecg-mayausd-branch-preflight-2020-pxrusd-mid3-interactive-linux/ecg-maya-usd/maya-usd/plugin/al/plugin/AL_USDMayaTestPlugin/py/testLayerManager.py", line 262, in test_anonymousLayerSerialisation
        self.assertIsNotNone(sublayer02)
    AssertionError: unexpectedly None
    
    ----------------------------------------------------------------------

Strangely this is the same reason for other PRs e.g. #1924 .

The unit test above should have been fixed (and have been merged) in c65e1d7

Any idea?

Update: did a fast-forward and the unit test should pass fine now.

@fabal fabal force-pushed the csyshing/only-bake-xform-at-top-level branch from f9ba6e0 to e717667 Compare December 20, 2021 04:47
@seando-adsk
Copy link
Collaborator

@csyshing Is there someone who can code review these changes? Once completed I will merge this PR.

@csyshing
Copy link
Collaborator Author

csyshing commented Jan 3, 2022

@seando-adsk , this PR has been reviewed internally in Animal Logic; on external, usually @kxl-adsk would do the review?

@seando-adsk
Copy link
Collaborator

@csyshing Okay. Krystian is off this week. Are you okay waiting until next week? If not we can find someone else to review.

@csyshing
Copy link
Collaborator Author

csyshing commented Jan 4, 2022

No problem @seando-adsk , it's not urgent to merge this PR.

kxl-adsk
kxl-adsk previously approved these changes Jan 10, 2022
kxl-adsk
kxl-adsk previously approved these changes Jan 11, 2022
@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jan 12, 2022
@kxl-adsk kxl-adsk merged commit 44df6f6 into Autodesk:dev Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
al Related to AnimalLogic plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants