Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T bailp/maya 112773/load on duplicate #1735

Merged
merged 5 commits into from
Oct 12, 2021

Conversation

pierrebai-adsk
Copy link
Collaborator

No description provided.

User prefer that duplicated model be loaded so the new model is visible.

Because the loaded status of a model can be affected by the loaded status of its ancestors, the new model could be unloaded on creation. We now load it explicitly after creation.
Analyze why the source prim was loaded or unloaded and create new load rules as needed for the destination to be similarly loaded or unloaded.
@pierrebai-adsk pierrebai-adsk added bug Something isn't working composition arc adsk Related to Autodesk plugin labels Sep 29, 2021
Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed offline, having a unit test for this change would be great.

The unit test fail before the fix. It tests most variations of loaded/unloaded of the prim being duplicated and its ancestor.
@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 12, 2021
@kxl-adsk kxl-adsk merged commit b2d9473 into dev Oct 12, 2021
@kxl-adsk kxl-adsk deleted the t_bailp/MAYA-112773/load-on-duplicate branch October 12, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adsk Related to Autodesk plugin bug Something isn't working composition arc ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants