Update primvars with instance interpolation when instancing is dirty. #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 31, 2021 10:25
… Add new test images to reflect the new behavior of USD 21.08.
williamkrick
commented
Aug 31, 2021
| return | ||
| imageVersion = None | ||
| if usdVersion < (0, 21, 8): | ||
| imageVersion = 'pre-21_08' |
There was a problem hiding this comment.
There are now two sets of images for the tests that follow this code. The main set in the regular folder is what the most up-to-date results are. The older images are in the pre-21_08 folder. In the future when we don't support any USD versions older than 21.08 we can remove those old images.
|
More question than a concern - do you know which change made this difference? Would be good to document. |
kxl-adsk
approved these changes
Aug 31, 2021
|
Yes it was the changes Pixar made for PixarAnimationStudios/OpenUSD#1515 |
williamkrick
added
the
ready-for-merge
kxl-adsk
deleted the
krickw/MAYA-110170/handle_instances_being_hidden_by_purpose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new test images to reflect the new behavior of USD 21.08.