MAYA-111503 - Fix GeomNurbsCurve import #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will help with #1397 but does not implement GeomBasisCurves import.
boudrey
reviewed
Aug 25, 2021
| // Remove front and back knots to match Maya representation. See | ||
| // "Managing different knot representations in external applications" | ||
| // section in MFnNurbsCurve documentation. | ||
| curveKnots.resize(curveKnots.size() - 1); |
There was a problem hiding this comment.
Should a size of at least 2 elements be checked before?
There was a problem hiding this comment.
That would happen only with a broken USD file, but it is indeed better if the code can survive that.
boudrey
approved these changes
Aug 26, 2021
JGamache-autodesk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help with #1397 but does not implement GeomBasisCurves import.