Pr/remove calls to configure resolver for asset under ar2 #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method has been deprecated and is being removed for Ar 2.0. Among other reasons, the resolver is a global resource and a method for configuring it for a single asset is misleading since the resolver may be used by many different assets at the same time. If a resolver has asset-specific resolution behaviors, they should be encoded in the resolver context created via ArResolver::CreateDefaultContextForAsset. The AL_USDMaya plugin had previously subverted this function to configure its resolver by passing in an arbitrary string to ConfigureResolverForAsset. This has been removed as part of this change, but this could be replaced in the future with ArResolver::CreateContextFromString, which allow a resolver to create a resolver context from an arbitrary string and was introduced in Ar 2.0.
kxl-adsk
reviewed
Jun 29, 2021
lib/mayaUsd/utils/utilFileSystem.cpp
Outdated
| #include <system_error> | ||
|
|
||
| namespace { | ||
| std::string generateUniqueName() |
There was a problem hiding this comment.
@dj-mcg How this change is related to AR 2.0?
There was a problem hiding this comment.
Yep - good catch - an internal patched change snuck in with my push. I'll be pushing a new version momentarily
kxl-adsk
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
I see this matches changes to https://github.com/PixarAnimationStudios/USD/blob/dev/pxr/usdImaging/usdviewq/__init__.py#L308. No concerns from my side but I will let @fabal review changes to AL proxy.
fabal
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has been deprecated and is being removed for Ar 2.0.
Among other reasons, the resolver is a global resource and a
method for configuring it for a single asset is misleading
since the resolver may be used by many different assets at
the same time. If a resolver has asset-specific resolution
behaviors, they should be encoded in the resolver context
created via ArResolver::CreateDefaultContextForAsset.
The AL_USDMaya plugin had previously subverted this function
to configure its resolver by passing in an arbitrary string
to ConfigureResolverForAsset. This has been removed as
part of this change, but this could be replaced in the
future with ArResolver::CreateContextFromString, which
allow a resolver to create a resolver context from an
arbitrary string and was introduced in Ar 2.0.