Use SdfComputeAssetPathRelativeToLayer to compute sublayer paths #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces custom logic that tried to anchor sublayer paths to the parent layer using direct calls to ArResolver. USD uses the Sdf function during composition, so using it will match USD's behavior. This also allows us to remove the use of ArResolver API that is deprecated under Ar 2.0.
seando-adsk
approved these changes
Jun 22, 2021
kxl-adsk
added
the
ready-for-merge
Yep! SdfFindOrOpenRelativeToLayer was added in 2016. |
dj-mcg
deleted the
pr/Use_SdfComputeAssetPathRelativeToLayer_to_Compute_Sublayer_Paths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces custom logic that tried to anchor sublayer
paths to the parent layer using direct calls to ArResolver.
USD uses the Sdf function during composition, so using
it will match USD's behavior. This also allows us to
remove the use of ArResolver API that is deprecated
under Ar 2.0.