-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate AE work from sandbox into dev #142
Conversation
* Bringing over the new AE templates for USD types. * Also brought over a fix to the mayaUsdProxyShape AE template.
…dev. Changes based on comments from PR: #91 * For these include file changes below mostly made the change only in 'lib/ufe' ** #include "mayaUsd/xxx" -> #include <mayaUsd/xxx> ** #include "maya/xxx" -> #include <maya/xxx> ** #include "ufe/xxx" -> #include <ufe/xxx> ** #include "pxr/xxx" -> #include <pxr/xxx> * reserve memory for vector
@robthebloke / @mattyjams - Can you please review this PR? It brings in the Attribute Editor templates (from refactoring_sandbox) and also address some of the concerns from: #91 I mostly focused on the comments about files in the "lib/ufe" folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me! Thanks Sean!
We don't currently have a PR build of Maya deployed that supports UFE V2, so I can't test it myself, but the changes make sense. I'm still a little unsure about our conventions for quotes vs. angle braces on header includes, but I punted on commenting on those assuming we'd address that later.
@mattyjams In the other PR you commented on how we were including some headers. We agree with you that all things external (such as maya/ufe/pxr) should be included using <>. So I addressed a bunch of those, but mostly only in the lib/ufe folder. We'll tackle the rest of the folders later once we've merged more of refactoring_sandbox into dev. |
Thanks @seando-adsk! Yeah, I definitely appreciate the follow-up from that earlier PR. I had initially been thinking of it as quotes for "system" headers and angle braces for "non-system", but I'm realizing now that "system" is too ill-defined and your external vs. internal criteria makes more sense. Looking through this PR, I think two things caught my eye:
Sorry to be so pedantic about the little stuff. I'm just trying to help figure out the conventions we want to follow as we're all getting more active working in the dev branch. Thanks again! |
…e_not_defined Post fix for earlier changes I made in lib/CMakeLists
MAYA-102108 - Integrate AE work from sandbox into dev
Added missing pieces from original merge of refactoring_sandbox into dev.
Changes based on comments from PR: #91
** #include "mayaUsd/xxx" -> #include <mayaUsd/xxx>
** #include "maya/xxx" -> #include <maya/xxx>
** #include "ufe/xxx" -> #include <ufe/xxx>
** #include "pxr/xxx" -> #include <pxr/xxx>