[mtoh] Add camera adapter to support physical camera parameters and configurable motion blur and depth-of-field.

[marsupial]

Running the test-suite locally to verify nothing has been broken, but as the change-set is quite large posting it now

Currently mtoh does motion-blur with two hard-coded samples t=frame and t=frame+1. We'd like this to be configurable, as these values/ranges are rarely used by our camera's, which are usually centered around the current frame. Additionally, reliance in the Hydra-projection matrix only for the camera means depth-of-field isn't currently supported.

These changes shouldn't affect Storm or other delegates that only use the Hydra render-pass view matrix.

• Removes mtohEnableMotionSamples, in favor of explicit shutter start and end settings. Setting start=0, end=1 with a camera's shutterAngle=360 is the equivalent of the old hard-coded mode.
• HdMayaSceneDelegate::InsertDag is refactored and templatized for the common pattern in adapter creation.
• HdMayaMeshAdapter::SamplePrimvar and HdMayaDagAdapter::SampleTransform call through to a templatized HdMayaDelegate::SampleValues method.
• Hydra HdCameraTokens->windowPolicy is exported as CameraUtilMatchHorizontally or CameraUtilMatchVertically to avoid any potential conversion issues with Maya's Fill or Overscan modes leaking out to HdRenderDelagtes.
• HdMayaDagAdapter matrix cache is reduced from two matrices to one.

TODO: Need a way to use the Maya viewport camera in a UsdProxyShape. Waiting until we can actually get the USD camera path when selected in the viewport to see what else can be done....The only way I can think of doing this right now is to build up a camera in the UsdProxyShape's stage, which has some downsides.

[pmolodo]

Overall makes sense to me - just a few small questions / suggestions.

[marsupial]

Think I covered it all. Closed out the -easy- issues, but left the more complicated ones open for you to do the same!

[pmolodo]

All the changes look good!

[kxl-adsk]

@marsupial Can you please apply clang-format so we can get PF results. Thank you.

[marsupial]

Hopefully latest will pass pre-flight.
Squashed everything down as it just seemed growing with too many correction-commits.

[kxl-adsk]

@marsupial Clang-format worked...but there are some build failures on windows.

[marsupial]

I took a wild guess at why MSVC is complaining about my perfectly legal code.
If it doesn't work, it'll probably be a lot faster to build the PR on a Windows machine (which I don't have access to) than me taking wild stabs.

-Thanks

[kxl-adsk]

@marsupial
There looks to be some sort of symbol clash on Windows. I won't have time to investigate, but here is a working patch that makes your changes successfully build on Windows
cameraAdapter.patch.txt

There is one additional point that makes me slightly nervous about this change - there is no regression test added to cover the changes you made. I wouldn't want us to rely on manual testing to validate that things continue to work since that's not going to work with all permutations of versions that we must support.

[marsupial]

Thanks for the patch...woulda taken me forever to figure that out change-submit-change-submit style.

I agree about the testing, but sadly Storm (and your VP-2 delegate) doesn't support HdCamera or motion-blur, best I could offer is some images proving our delegate matches the GL-Viewport in all fit-modes, and editing shutter start, end, and angle gives the expected results. Nothing was changed in the delegate for this patch, which matches what HdKarma does in Houdini.

This was written so we can start doing more advanced play-blasting from Maya, so it should be getting exercised and any breakage will be reported to me pretty quickly.

[kxl-adsk]

@marsupial Looks like there is still something to investigate. We currently don't run interactive tests as part of PF and only run them before merging changes (it's something we are hoping to fix very soon). The following test is failing with your change:

49/148 Test  #36: testMtohCommand .................................***Failed   84.24 sec
Maya.env file copied from C:/Users/ligenzk/Documents/maya/2020/ to E:/Dev/usd/_workspaces_latest/Maya_USD_PR_2020/build/RelWithDebInfo/test/Temporary/testMtohCommand/2020/Maya.env
MAYA_DEBUG_NO_SAVE_ON_CRASH is set.
Initialized VP2.0 renderer {
  Version : 2016.11.53.12. Feature Level 5.
  Adapter : Quadro K5000/PCIe/SSE2
  Vendor ID: 4318. Device ID : 0
  Driver : .
  API : OpenGL V.4.5.
  Max texture size : 16384 * 16384.
  Max tex coords : 32
  Shader versions supported (Vertex: 5, Geometry: 5, Pixel 5).
  Shader compiler profile : (Best card profile)
  Active stereo support available : 0
  GPU Memory Limit : 4096 MB.
  CPU Memory Limit: 62004.9 MB.
  MultiDraw consolidation: enabled
}
OpenCL evaluator is attempting to initialize OpenCL.
OpenCL evaluator failed to initialize clew.
F.....
======================================================================
FAIL: test_createRenderGlobals (__main__.TestCommand)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "E:/Dev/usd/_workspaces_latest/Maya_USD_PR_2020/build/RelWithDebInfo/test/lib/mayaUsd/render/mayaToHydra\testMtohCommand.py", line 97, in test_createRenderGlobals
    "defaultRenderGlobals.mtohEnableMotionSamples"))
AssertionError: False is not true
----------------------------------------------------------------------
Ran 6 tests in 4.761s
FAILED (failures=1)
Runtime Error: in GlfPostPendingGLErrors at line 85 of E:\Dev\usd\usd\pxr\imaging\glf\diagnostic.cpp -- GL error: invalid operation, reported from void __cdecl pxrInternal_v0_20__pxrReserved__::GlfSimpleShadowArray::_FreeBindfulTextures(void)

[marsupial]

Should be passing now, just a pref-name change.

[kxl-adsk]

LGTM, thank you.