Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-110410 Author a default value for color & opacity if none are present. #1254

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

williamkrick
Copy link
Contributor

No description provided.

@williamkrick williamkrick added the vp2renderdelegate Related to VP2RenderDelegate label Mar 15, 2021
@huidong-chen
Copy link

LGTM.

@kxl-adsk FYI. This fix seems to have some connection to the issue Luc and you found last week when testing a scene without authored color?

@williamkrick williamkrick added the ready-for-merge Development process is finished, PR is ready for merge label Mar 16, 2021
@kxl-adsk
Copy link

@HdC-adsk I don't think it will solve the problem. The solution was to author display color...but we haven't author opacity in the regression test.

@williamkrick
Copy link
Contributor Author

@HdC-adsk does that other issue block this one? Maybe you just forgot to approve the review?

Copy link

@huidong-chen huidong-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking. I was just waiting for Krystian to confirm.

@kxl-adsk kxl-adsk merged commit c9e4df3 into dev Mar 16, 2021
@kxl-adsk kxl-adsk deleted the krickw/MAYA-110410/usdskel_crash_in_vp2renderdelegate branch March 16, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants