Add per instance inherited data support to Vp2RenderDelegate. #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm planning to add a test for this as well. |
|
I guess basisCurves has the same requirement, no? |
huidong-chen
reviewed
Mar 1, 2021
huidong-chen
reviewed
Mar 1, 2021
huidong-chen
reviewed
Mar 1, 2021
huidong-chen
reviewed
Mar 1, 2021
williamkrick
commented
Mar 1, 2021
williamkrick
commented
Mar 1, 2021
huidong-chen
reviewed
Mar 1, 2021
huidong-chen
approved these changes
Mar 1, 2021
|
@HdC-adsk For basisCurves I think you are correct, we need to make changes there too. I'm not sure if I would rather do the common parent class for mesh & basisCurves first or not. I'll spend some time this afternoon and decided to either make the common parent class or do basisCurves specific changes. |
…nstances have data.
huidong-chen
approved these changes
Mar 3, 2021
|
There is still an outstanding issue. I'm working with USD 21.02 locally and the behavior of the tests in USD 20.05 and 20.02 is different. I need to figure out which version is producing desirable results (hopefully 21.02 is correct) and then decide what to do about it. |
williamkrick
assigned williamkrick and ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk and williamkrick
williamkrick
added
the
ready-for-merge
williamkrick
removed
the
ready-for-merge
williamkrick
added
ready-for-merge
|
@kxl-adsk found an issue with Maya 2020 + USD 20.05, I will investigate. |
williamkrick
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #327