-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-106484 add support for 16-bits textures in VP2 renderer delegate. #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added Krystian as reviewer mostly so he can be aware of the progress on this task. |
I always assume VS will apply the format automatically. It mostly does, but some code changes fail to trigger its reformat...
huidong-chen
suggested changes
Mar 1, 2021
- Use Intel TBB to do parallel conversion of the texture. - Use it also for the 8-bits conversion. - Removed RGB colorspace check. - Improved the error report.
huidong-chen
reviewed
Mar 1, 2021
huidong-chen
reviewed
Mar 3, 2021
huidong-chen
approved these changes
Mar 3, 2021
There was no gain.
kxl-adsk
approved these changes
Mar 4, 2021
huidong-chen
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-for-merge
Development process is finished, PR is ready for merge
vp2renderdelegate
Related to VP2RenderDelegate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.