Fix bbox computation for purposes, add test. #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxl-adsk
reviewed
Feb 11, 2021
lib/mayaUsd/ufe/UsdObject3d.cpp
Outdated
| @@ -75,7 +75,9 @@ Ufe::BBox3d UsdObject3d::boundingBox() const | |||
| // as the time. | |||
|
|
|||
| auto bbox = UsdGeomImageable(fPrim).ComputeUntransformedBound( | |||
| getTime(sceneItem()->path()), UsdGeomTokens->default_); | |||
| getTime(sceneItem()->path()), UsdGeomTokens->default_, | |||
| UsdGeomTokens->guide, UsdGeomTokens->proxy, UsdGeomTokens->render | |||
There was a problem hiding this comment.
On the proxy shape, we have toggles that control what will be rendered. I wonder if we shouldn't be respecting it here because purpose helps you manage complexity and including everything when computing bounding box may be simply too expensive.
ppt-adsk
commented
Feb 12, 2021
| @@ -333,6 +334,54 @@ UsdTimeCode getTime(const Ufe::Path& path) | |||
| return proxyShape->getTime(); | |||
| } | |||
|
|
|||
| TfTokenVector getProxyShapePurposes(const Ufe::Path& path) | |||
There was a problem hiding this comment.
Copy-pasted and adapted from getTime(). Arguably, getTime() itself has duplication from the stage map, and all calls to nameToDagPath() in the existing code base should be examined for performance and centralized. This is out of scope for the current branch.
| @@ -30,6 +30,10 @@ def assertVectorAlmostEqual(testCase, a, b, places=7): | |||
| for va, vb in zip(a, b): | |||
| testCase.assertAlmostEqual(va, vb, places) | |||
|
|
|||
| def assertVectorNotAlmostEqual(testCase, a, b, places=7): | |||
There was a problem hiding this comment.
Thought I would need this, ended up not using it, but left it in, as it's useful.
kxl-adsk
approved these changes
Feb 19, 2021
seando-adsk
approved these changes
Feb 19, 2021
ppt-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.