Use data model undo framework for attribute undo. #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Jan 29, 2021
| @@ -140,6 +143,31 @@ void setUsdAttributeVectorFromUfe( | |||
| UFE_ASSERT_MSG(b, kErrorMsgFailedSet); | |||
| } | |||
|
|
|||
| template <typename T, typename A = MayaUsd::ufe::TypedUsdAttribute<T>> | |||
| class SetUndoableCommand : public Ufe::UndoableCommand | |||
There was a problem hiding this comment.
Simple class that uses the new UsdUndoableItem support.
| @@ -557,3 +557,50 @@ def testObservation(self): | |||
| self.assertEqual(ball34Obs.notifications, 3) | |||
| self.assertEqual(ball35Obs.notifications, 3) | |||
| self.assertEqual(globalObs.notifications, 7) | |||
|
|
|||
| # Run last to avoid file new disturbing other tests. | |||
| def testZAttrChangeRedoAfterPrimCreateRedo(self): | |||
There was a problem hiding this comment.
Test-Driven Development: wrote test first, it failed (crashed), coded fix, test now passes.
kxl-adsk
approved these changes
Jan 30, 2021
seando-adsk
approved these changes
Feb 1, 2021
|
All Windows Python 2 builds failed because of lack of disk space errors, but other builds succeeded. I therefore believe this pull request is good to go. |
ppt-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UsdAttribute derived classes were not overriding the Ufe::Attribute::setCmd() virtual. This meant that we were using the implementation from UFE, rather than our new, data model correct undo system. This was bad in two ways:
Now fixed, with an automated test to validate the fix.