MAYA105624 make xform reading more uniform #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two private functions that reads transforms: _pushUSDXformOpToMayaXform() and _pushUSDXformToMayaXform(). The first was using the earliest-time time code when no time interval were used for importing. The other was using default-time. Using default-time prevented importing the transform since their time code did not match and the iimportaed mesh would have bad transform (they would all have identity matrix). This change make both code paths use earliest-time. This fixes bad import of geometry when not importing animation data in Maya.
kxl-adsk
approved these changes
Jan 28, 2021
|
@pierrebai-adsk Would you mind adding a unit test to this PR? |
mattyjams
approved these changes
Feb 2, 2021
pierrebai-adsk
added
the
ready-for-merge
… qithout loading anim data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two private functions that reads transforms: _pushUSDXformOpToMayaXform() and _pushUSDXformToMayaXform().
The first was using the earliest-time time code when no time interval were used for importing. The other was using default-time.
Using default-time prevented importing the transform since their time code did not match and the iimportaed mesh would have bad transform (they would all have identity matrix).
This change make both code paths use earliest-time. This fixes bad import of geometry when not importing animation data in Maya.