make use of PXR_OVERRIDE_PLUGINPATH_NAME everywhere #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seando-adsk
reviewed
Jan 27, 2021
| @@ -32,7 +32,7 @@ class testUsdExportCustomConverter(unittest.TestCase): | |||
| def setUpClass(cls): | |||
| # In case tests are run in parallel, make sure we export to separate | |||
| # directories: | |||
| plugin_path = os.getenv("PXR_PLUGINPATH_NAME") | |||
| plugin_path = os.getenv("@PXR_OVERRIDE_PLUGINPATH_NAME@") | |||
There was a problem hiding this comment.
Thats a neat trick using the configure_file
There was a problem hiding this comment.
Honestly, I wanted to find a way that DIDN'T have to use configure_file... but I couldn't think of any alternative. At least this works!
seando-adsk
approved these changes
Jan 27, 2021
kxl-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PXR_OVERRIDE_PLUGINPATH_NAME is already used in some places, but it's coverage is spotty - make use of it everywhere, instead of hard-coding PXR_PLUGINPATH_NAME