use std::function instead of boost::function #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for consistency with rest of code base, fewer dependencies (because project requires c++11), and because I got a build error becuase boost::function had only been forward declared
|
+1 to this from me. I ran into this as well and had added an include for <boost/function.hpp>, but I like this using the one in std better. |
|
Feeling the same here, went with std::function. |
|
Just for reference, this same change had already been applied in the original USD repo as f22edbc. |
mattyjams
pushed a commit
to mattyjams/maya-usd
that referenced
this pull request
Sep 26, 2019
…07-19 Squashed commits of Draco plugin for USD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for consistency with rest of code base, fewer dependencies (because project
requires c++11), and because I got a build error becuase boost::function
had only been forward declared