Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected instanced object is slowing down 5x the viewport #341

Closed
Xaia opened this issue Mar 8, 2020 · 13 comments
Closed

Selected instanced object is slowing down 5x the viewport #341

Xaia opened this issue Mar 8, 2020 · 13 comments
Assignees
Labels
bug Something isn't working mtoh Related to legacy Maya to Hydra plugin. reproduced Issue has been reproduced vp2renderdelegate Related to VP2RenderDelegate

Comments

@Xaia
Copy link

Xaia commented Mar 8, 2020

Describe the bug
Selected instanced object is slowing down the viewport (MTOH and VP2)

Steps to reproduce
Steps to reproduce the behavior:

  1. Bring in instanced stage with or without animation
  2. Select the object

Expected behavior
There should be no such big slowdowns.

Attachments
VhBB107mbt

Specs (if applicable):

  • Windows 10
  • Maya Beta PR113
@Xaia Xaia added the bug Something isn't working label Mar 8, 2020
@kxl-adsk
Copy link

kxl-adsk commented Mar 8, 2020

@Xaia This is using VP2 render delegate? (not mtoh)

@kxl-adsk kxl-adsk added the question Further information is requested label Mar 8, 2020
@Xaia
Copy link
Author

Xaia commented Mar 8, 2020

@kxl-adsk
It's both, MTOH and VP2

@kxl-adsk kxl-adsk added mtoh Related to legacy Maya to Hydra plugin. vp2renderdelegate Related to VP2RenderDelegate and removed question Further information is requested labels Mar 8, 2020
@kxl-adsk
Copy link

kxl-adsk commented Mar 8, 2020

Selection is handled very differently in VP2RenderDelegate vs mtoh. We may decide to split this into two separate issues.

@huidong-chen
Copy link

huidong-chen commented Mar 9, 2020

@Xaia Thanks for reporting the issue.

This is not selection performance but the selection highlight wireframe draw performance.

I notice that there is a USD point instancer in the scene in the recording. Is it possible to share us with the scene? Thanks.

@Xaia
Copy link
Author

Xaia commented Mar 9, 2020

@HdC-adsk
yes, this is an instanced animation.
file is too big to upload here, link to gdrive instead:
https://drive.google.com/file/d/1KvqjAG3sXCgfrhnXkvUtiePpdIWmbRjf/view?usp=sharing

@huidong-chen
Copy link

@Xaia Thanks for sharing.

@huidong-chen
Copy link

huidong-chen commented Mar 12, 2020

On a NVIDIA Quadro M2000 card I can see a 2x slow down when displaying selection highlight. The scene drawing performance is bound on GPU according to Maya profiler, and when selection highlight is displayed there are nearly 2x GPU workloads (shaded + green wireframe), so I think the 2x slowdown makes sense.

@Xaia Can I ask about your machine config, esp. GPU? We will need this info to reproduce the issue.

@santosg87 Can you reproduce the 5x slowdown?

For record, here is the Maya profile I get from the scene using the following MEL script.

profiler -reset;
profiler -sampling true;

select -cl;

for ($i=1; $i <= 10; $i++)
{
refresh;
}

select -r Mash_instancer_animation_usdShape;

for ($i=1; $i <= 10; $i++)
{
refresh;
}

select -cl;

profiler -sampling false;

@Xaia
Copy link
Author

Xaia commented Mar 12, 2020

@HdC-adsk
I am running maya on 2x GTX 1070 8gb, Ryzen 9 3950x, 64gb 3600mhz memory and samsung gen3 m.2 hdd.

@santosd
Copy link
Collaborator

santosd commented Mar 13, 2020

I took a look on a machine with an Nvidia Quadro 5000 and in the viewport when I turn on the frame rate, I am seeing a little more than 2x slower when I have the USD instanced object selected. Without selection I see a frame rate of about 15.2 and with the selection I see a frame rate of about 5.6 Here is the profile I got using @HdC-adsk 's script.

@santosd santosd added the reproduced Issue has been reproduced label Mar 13, 2020
@williamkrick
Copy link
Contributor

I believe this issue is related to the problem in #575. With the fix for that issue in place (either in PR116 which should include #575, or when using an updated version of USD) I find the performance while selected is "as expected".

My expected performance is selectedFrameTime ~= shadedFrameTime + wireframeFrameTime, which I found to be true with those fixes in place.

@santosg87
Copy link
Collaborator

@Xaia are you able to test this on PR116 and close it? the PR is available for download and should contain the fix, as mentioned by williamkrick :)

@Xaia
Copy link
Author

Xaia commented Jul 6, 2020

@santosg87 Just checked if something changed in the new version and I am getting worse results than in PR113.
34pVNI35iy

@Xaia
Copy link
Author

Xaia commented Jul 6, 2020

Recreated the scene with 100k spheres and published fresh usd file and its actually much better. Getting 25 frames without selection and 10 with selection.
I guess old file has issues.
Is there a way to check amount of instances?
Cheers!

@Xaia Xaia closed this as completed Jul 6, 2020
ppt-adsk pushed a commit that referenced this issue Feb 28, 2023
#341)

* MAYA-127211 : Fix Arnold skydome lights not working even when a texture is set.
For the color, it is ignored by HdStorm in USD 22.11 when there is no texture. And when there is no texture, the light is just ignored at all in HdStorm.

* MAYA-127211 : double check it's a aiSkydomeLight

* MAYA-127211 : Fix merge conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mtoh Related to legacy Maya to Hydra plugin. reproduced Issue has been reproduced vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

No branches or pull requests

6 participants