Skip to content

Commit

Permalink
- ${CMAKE_BINARY_DIR}/include is now added privately in mayaUsd proje…
Browse files Browse the repository at this point in the history
…ct and didn't really belong in the public list. This makes it more explicit and clear as where the include directories are coming from.

- Removed unused ${MAYAUSD_INCLUDE_DIR} variable.
  • Loading branch information
Hamed Sabri committed Mar 5, 2020
1 parent e402ced commit 904b394
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ endif()
# -----------------------------------------------------------------------------
target_include_directories(${PROJECT_NAME}
PUBLIC
${CMAKE_BINARY_DIR}/include
${MAYA_INCLUDE_DIRS}
${PXR_INCLUDE_DIRS}
$<$<BOOL:${UFE_FOUND}>:${UFE_INCLUDE_DIR}>
PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}
${CMAKE_BINARY_DIR}/include
)

# -----------------------------------------------------------------------------
Expand Down
12 changes: 10 additions & 2 deletions lib/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,12 @@ target_compile_definitions(${PYTHON_TARGET_NAME}
)

# -----------------------------------------------------------------------------
# properties
# include directories
# -----------------------------------------------------------------------------
set_python_module_property(${PYTHON_TARGET_NAME})
target_include_directories(${PYTHON_TARGET_NAME}
PRIVATE
${CMAKE_BINARY_DIR}/include
)

# -----------------------------------------------------------------------------
# link libraries
Expand All @@ -56,6 +59,11 @@ target_link_libraries(${PYTHON_TARGET_NAME}
${PROJECT_NAME}
)

# -----------------------------------------------------------------------------
# properties
# -----------------------------------------------------------------------------
set_python_module_property(${PYTHON_TARGET_NAME})

# -----------------------------------------------------------------------------
# run-time search paths
# -----------------------------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions lib/render/mayaToHydra/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ target_include_directories(${TARGET_NAME}
"${CMAKE_CURRENT_SOURCE_DIR}/.."
${MAYA_INCLUDE_DIRS}
${CMAKE_BINARY_DIR}/usd
${CMAKE_BINARY_DIR}/include
$<$<BOOL:${UFE_FOUND}>:${UFE_INCLUDE_DIR}>
)

Expand Down
12 changes: 10 additions & 2 deletions lib/ufe/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,12 @@ target_compile_definitions(${UFE_PYTHON_TARGET_NAME}
)

# -----------------------------------------------------------------------------
# properties
# include directories
# -----------------------------------------------------------------------------
set_python_module_property(${UFE_PYTHON_TARGET_NAME})
target_include_directories(${UFE_PYTHON_TARGET_NAME}
PRIVATE
${CMAKE_BINARY_DIR}/include
)

# -----------------------------------------------------------------------------
# link libraries
Expand All @@ -133,6 +136,11 @@ target_link_libraries(${UFE_PYTHON_TARGET_NAME}
${PROJECT_NAME}
)

# -----------------------------------------------------------------------------
# properties
# -----------------------------------------------------------------------------
set_python_module_property(${UFE_PYTHON_TARGET_NAME})

# -----------------------------------------------------------------------------
# run-time search paths
# -----------------------------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions lib/usd/hdMaya/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ target_include_directories(${TARGET_NAME}
PRIVATE
"${CMAKE_CURRENT_SOURCE_DIR}/.."
$<$<BOOL:${UFE_FOUND}>:${UFE_INCLUDE_DIR}>
${CMAKE_BINARY_DIR}/include
PUBLIC
${CMAKE_CURRENT_SOURCE_DIR}
"${CMAKE_CURRENT_BINARY_DIR}/.."
Expand Down
2 changes: 1 addition & 1 deletion plugin/adsk/plugin/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ target_compile_definitions(${TARGET_NAME}
# -----------------------------------------------------------------------------
target_include_directories(${TARGET_NAME}
PRIVATE
${MAYAUSD_INCLUDE_DIR}
${CMAKE_BINARY_DIR}/include
${PXR_INCLUDE_DIRS}
$<$<BOOL:${UFE_FOUND}>:${UFE_INCLUDE_DIR}>
)
Expand Down
1 change: 0 additions & 1 deletion plugin/al/plugin/AL_USDMayaTestPlugin/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ target_include_directories(${TARGET_NAME}
PRIVATE
${GTEST_INCLUDE_DIRS}
${MAYA_INCLUDE_DIRS}
${MAYAUSD_INCLUDE_DIR}
"../../lib/AL_USDMaya"
"../../schemas"
${MAYATEST_INCLUDE_LOCATION}
Expand Down

0 comments on commit 904b394

Please sign in to comment.