Refactor DOM creation #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluehne
force-pushed
the
patrick/refactor-dom-layout
branch
from
f0ed9c9 to
fada710
Compare
This refactoring simplifies the HTML necessary to build charts by moving the creation of required wrappers to the JavaScript side. This approach has multiple benefits. First, the HTML part is more lightweight. Hence, future additions to the charts (such as action bars) will require much less changes to the HTML. Second, we have more control over the layout on the JavaScript side without having to touch the HTML part. Third, information concerning the chart content is grouped and separated from the layout part more nicely in this way. Finally, with this preparation, we could render placeholders more nicely in the future, as they have a distinct style now. The existing charts are adjusted to these changes and produce pixel-wise identical visualizations. Additionally, this unifies the way how charts, tables, and collaboration graphs are rendered.
pluehne
force-pushed
the
patrick/refactor-dom-layout
branch
from
fada710 to
ab81166
Compare
|
Would be good to update |
|
@filmaj: Good catch, I’ll do this later! |
|
@filmaj Thanks for the review 👍 Do you generally agree with these changes? It's easier to review with this link: https://github.com/Autodesk/hubble/pull/81/files?w=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring simplifies the HTML necessary to build charts by moving the creation of required wrappers to the JavaScript side.
This approach has multiple benefits.
The existing charts are adjusted to these changes and produce pixel-wise identical visualizations. Additionally, this unifies the way how charts, tables, and collaboration graphs are rendered.