Switch user activity chart to 4-week intervals #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user activity chart stems from before most sliding windows and aggregation methods were switched from 30-day intervals to 4-week intervals. The benefit of this is that weekends are evened out, which avoids accidentally misinterpreting some fluctuations. This changes the user activity chart accordingly for consistency. Additionally, the time range computation in the updater report receives a minor refactoring based on the more recent reports. Note that this change will invalidate previously recorded data based on 30-day intervals. However, no action is taken, because the difference between data aggregated over 28 and 30 days is expected to be subtle.
pluehne
force-pushed
the
patrick/4-weeks-in-user-activity-chart
branch
from
1964544 to
75cce07
Compare
|
@larsxschneider: I rebased this on top of the merged changes of #137 and #138. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user activity chart stems from before most sliding windows and aggregation methods were switched from 30-day intervals to 4-week intervals. The benefit of this is that weekends are evened out, which avoids accidentally misinterpreting some fluctuations.
This changes the user activity chart accordingly for consistency.
Additionally, the time range computation in the updater report receives a minor refactoring based on the more recent reports.
Note that this change will invalidate previously recorded data based on 30-day intervals. However, no action is taken, because the difference between data aggregated over 28 and 30 days is expected to be subtle.
Resolves #129.