Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): use getBucketACL instead of headBucket to check if bucket exist #879

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

ShadowySpirits
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a8f53e) 55.00% compared to head (4fe2fb1) 54.97%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #879      +/-   ##
============================================
- Coverage     55.00%   54.97%   -0.04%     
+ Complexity     1246     1243       -3     
============================================
  Files           133      133              
  Lines          8535     8535              
  Branches        789      789              
============================================
- Hits           4695     4692       -3     
  Misses         3426     3426              
- Partials        414      417       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.18% <ø> (-0.11%) ⬇️
RocketMQ Store 73.57% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@ShadowySpirits ShadowySpirits marked this pull request as ready for review January 4, 2024 02:26
@superhx superhx enabled auto-merge (squash) January 4, 2024 02:29
@ShadowySpirits ShadowySpirits merged commit e10b95f into main Jan 4, 2024
7 of 9 checks passed
@ShadowySpirits ShadowySpirits deleted the check_s3 branch January 4, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants