Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepend CRC32 checksum header to ops stream record #601

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

lizhanhui
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #601 (3070509) into main (bbc1808) will increase coverage by 0.26%.
Report is 3 commits behind head on main.
The diff coverage is 66.66%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #601      +/-   ##
============================================
+ Coverage     58.80%   59.07%   +0.26%     
- Complexity     1933     1943      +10     
============================================
  Files           198      199       +1     
  Lines         12959    13054      +95     
  Branches       1222     1195      -27     
============================================
+ Hits           7621     7711      +90     
- Misses         4724     4728       +4     
- Partials        614      615       +1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 50.50% <ø> (+1.30%) ⬆️
RocketMQ Proxy 43.45% <ø> (-1.11%) ⬇️
RocketMQ Store 78.08% <66.66%> (+0.56%) ⬆️
RocketMQ Stream 60.49% <ø> (+<0.01%) ⬆️
RocketMQ Metadata 38.28% <ø> (+1.07%) ⬆️
Files Coverage Δ
...utomq/rocketmq/store/exception/StoreErrorCode.java 100.00% <100.00%> (ø)
...tmq/store/queue/DefaultLogicQueueStateMachine.java 88.02% <100.00%> (+1.58%) ⬆️
.../com/automq/rocketmq/store/util/SerializeUtil.java 92.77% <64.00%> (-5.14%) ⬇️

... and 73 files with indirect coverage changes

Copy link

github-actions bot commented Nov 8, 2023

Qodana for JVM

2 new problems were found

Inspection name Severity Problems
Suspicious collection method call 🔶 Warning 1
Unchecked warning 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@lizhanhui lizhanhui changed the title fix: flip buffer before read ops feat: prepend CRC32 checksum header to ops stream record Nov 9, 2023
@ShadowySpirits ShadowySpirits merged commit 0f86ed8 into main Nov 9, 2023
10 checks passed
@ShadowySpirits ShadowySpirits deleted the fix_590 branch November 9, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants