Add 'wasm-unsafe-eval' to custom CSP (fix #906) #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that some dependencies (at least argon2-browser) require allowing WebAssembly at the CSP level. Recent Firefox allows that by default, but having your own CSP means this extension won't be able to benefit from this automatically.
|
FWIW, I do not intend to do more work on this pull request. Feel free to steal / adjust and merge at your own convenient. :) |
|
Thanks for this! Although, it seems that MV2 extensions are not affected by this just yet per bug 1770909 |
|
Indeed, we changed course after we learned that it would impact too many add-ons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some dependencies (at least argon2-browser) require allowing WebAssembly at the CSP level.
Recent Firefox allows that by default, but having your own CSP means this extension won't be able to benefit from this automatically.