Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy contract connections #51

Merged
merged 14 commits into from
May 10, 2019
Merged

Legacy contract connections #51

merged 14 commits into from
May 10, 2019

Conversation

szerintedmi
Copy link
Member

@szerintedmi szerintedmi commented May 9, 2019 •
edited
Loading

  • added tests to connect to legacy Exchange
  • legacy AugmintToken connections & tests (updated to @augmint/contracts 1.0.11 for it )

@szerintedmi szerintedmi requested review from phraktle and rszaloki May 9, 2019 17:35
@szerintedmi szerintedmi mentioned this pull request May 9, 2019
Merged
phraktle
phraktle approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@phraktle phraktle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it would be preferred to not have hardcoded address lists to distinguish contracts in various roles. This requires a slight change to the abiniser descriptors though, in the meantime we can let this slide ;)

@phraktle phraktle merged commit cc18983 into staging May 10, 2019
@phraktle phraktle deleted the legacyconnections branch May 10, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phraktle phraktle phraktle approved these changes

@rszaloki rszaloki Awaiting requested review from rszaloki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szerintedmi @phraktle