Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/84 artwork more info #98

Merged
merged 11 commits into from
Jan 18, 2023
Merged

Feature/84 artwork more info #98

merged 11 commits into from
Jan 18, 2023

Conversation

Gyubam
Copy link
Contributor

@Gyubam Gyubam commented Jan 17, 2023 •
edited by ChooSeoyeon
Loading

πŸ“Œ κ΄€λ ¨ 이슈

close #84

✨ μž‘μ—… λ‚΄μš©

  • ν…ŒμŠ€νŠΈ μ½”λ“œ κ΄€λ ¨ μ—λŸ¬ μˆ˜μ •
  • μž‘ν’ˆ 등둝 api μˆ˜μ •
  • μž‘ν’ˆ 상세 쑰회 api κ΅¬ν˜„

πŸ“š 기타

JunYoung-C
JunYoung-C reviewed Jan 17, 2023
View reviewed changes
src/test/resources/application.yml Outdated
url: ${application.spring.datasource.url}
username: ${application.spring.datasource.username}
password: ${application.spring.datasource.password}
driver-class-name: com.mysql.cj.jdbc.Driver
Copy link
Contributor

@JunYoung-C JunYoung-C Jan 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datasourceλ₯Ό μƒλž΅ν•˜λ©΄ h2 inmemory λͺ¨λ“œλ‘œ μžλ™μœΌλ‘œ λ™μž‘ν•˜λŠ” κ²ƒμœΌλ‘œ μ•Œκ³ μžˆμŠ΅λ‹ˆλ‹€. ν˜Ήμ‹œ μ €λ ‡κ²Œ μΆ”κ°€ν•˜λ©΄ mysql둜 λ™μž‘ν•˜κ³ , 둜컬 mysql db와 데이터 좩돌이 λ°œμƒν•  수 μžˆμ§€ μ•Šλ‚˜μš©??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„μ•„ λ„΅. 이 뢀뢄은 μ œκ°€ μˆ™μ§€λ₯Ό λͺ»ν•΄μ„œ μˆ˜μ •ν•΄μ„œ μ˜¬λ¦¬κ² μŠ΅λ‹ˆλ‹€!

JunYoung-C
JunYoung-C reviewed Jan 17, 2023
View reviewed changes
src/main/java/com/sptp/backend/art_work/repository/ArtWork.java
@@ -32,7 +32,7 @@ public class ArtWork extends BaseEntity {

private String material;

private String size;
private Integer productionYear;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ³€κ²½λœ ν•„λ“œλŠ” erd에 λ°˜μ˜ν•΄μ£Όμ„Έμš”!!

JunYoung-C
JunYoung-C reviewed Jan 17, 2023
View reviewed changes
src/main/java/com/sptp/backend/art_work/web/dto/request/ArtWorkSaveRequestDto.java
private String status;
private String statusDescription;
private Integer width;
private Integer length;
private Integer height;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

응집도 높은 ν•„λ“œλ“€μ€ 객체둜 λ¬Άκ³ , @Embeddedλ₯Ό ν™œμš©ν•˜λ©΄ 쒋을 것 κ°™μ•„μš”!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅ ν†΅ν•©λœ 객체둜 κ΄€λ¦¬ν•˜λŠ”κ²Œ λ§žλŠ”κ²ƒ κ°™λ„€μš©

JunYoung-C
JunYoung-C reviewed Jan 17, 2023
View reviewed changes
src/main/java/com/sptp/backend/art_work/service/ArtWorkService.java Outdated
.mainImage(findArtWork.getMainImage())
.artistImage(findArtist.getImage())
.images(artWorkImages.stream().map(m -> m.getImage()).collect(Collectors.toList()))
.keywords(artWorkKeywords.stream().map(m->KeywordMap.getKeywordName(m.getKeywordId())).collect(Collectors.toList()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μœΌμ–΄ κΈ°λ„€μš”. ν˜Ήμ‹œ μ œκ°€ μž‘μ„±ν•œ ChatRoomDetailResponse λ‚΄λΆ€ 클래슀의 from()처럼 좔상화 ν•˜λŠ” 방법은 μ–΄λ–»κ²Œ μƒκ°ν•˜μ‹œλ‚˜μš”! μ˜κ²¬μ„ μ£Όκ³ λ°›κ³  μ‹ΆμŠ΅λ‹ˆλ‹Ή

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ λ§μ”€ν•˜μ‹  λΆ€λΆ„ μ°Έκ³ ν•΄μ„œ μˆ˜μ •ν•΄λ³΄κ² μŠ΅λ‹ˆλ‹€!

JunYoung-C
JunYoung-C reviewed Jan 17, 2023
View reviewed changes
src/main/java/com/sptp/backend/art_work/web/ArtWorkController.java Outdated
@@ -27,4 +30,13 @@ public ResponseEntity<Void> saveArtWork(@AuthenticationPrincipal CustomUserDetai

return new ResponseEntity(HttpStatus.OK);
}

// μž‘ν’ˆ 상세 쑰회
@GetMapping("/art-work/{artWorkId}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/art-worksκ°€ μ•„λ‹Œ /art-work둜 ν•˜μ‹  μ˜λ„κ°€ μžˆμœΌμ‹€κΉŒμš©

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κΈ°μ‘΄ μž‘ν’ˆλ“±λ‘μ΄ /art-work λ‹€ λ³΄λ‹ˆ 상세 λ˜ν•œ μ΄λ ‡κ²Œ μž‘μ„± ν•œκ±΄λ°,
νšŒμ› κ΄€λ ¨ end point도 /membersλ‹€ λ³΄λ‹ˆκΉŒ /art-works둜 ν†΅μΌν•˜λŠ”κ²Œ λ§žλŠ”κ²ƒ κ°™μŠ΅λ‹ˆλ‹€

JunYoung-C
JunYoung-C approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@JunYoung-C JunYoung-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •μ‚¬ν•­ μ „λΆ€ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. κ³ μƒν•˜μ…¨μ–΄μš”!

ChooSeoyeon
ChooSeoyeon reviewed Jan 18, 2023
View reviewed changes
src/main/java/com/sptp/backend/member/web/dto/response/PreferredArtWorkResponse.java
@@ -9,6 +9,8 @@
@Builder
public class PreferredArtWorkResponse {

private Long id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λͺ©λ‘ μ‘°νšŒμ—μ„œ idλ₯Ό μΆ”κ°€ν•˜μ‹  μ΄μœ κ°€ κΆκΈˆν•©λ‹ˆλ‹Ή 제 것도 λ„£μ–΄μ•Ό ν•˜λ‚˜ ν•΄μ„œμš©,,

ChooSeoyeon
ChooSeoyeon approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@ChooSeoyeon ChooSeoyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€! μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹Ή

@JunYoung-C JunYoung-C merged commit 5e1b93c into develop Jan 18, 2023
@JunYoung-C JunYoung-C deleted the feature/84-artwork-more-info branch January 18, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChooSeoyeon ChooSeoyeon ChooSeoyeon approved these changes

@JunYoung-C JunYoung-C JunYoung-C approved these changes

Assignees

@Gyubam Gyubam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] μž‘ν’ˆ 상세 쑰회
3 participants
@Gyubam @ChooSeoyeon @JunYoung-C