Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/77 update member images #79

Merged
merged 5 commits into from
Jan 15, 2023
Merged

Conversation

ChooSeoyeon
Copy link
Member

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ

close #77

โœจ ์ž‘์—… ๋‚ด์šฉ

  • ํšŒ์›/์ž‘๊ฐ€ ์ •๋ณด ์ˆ˜์ • api์—์„œ ์ด๋ฏธ์ง€ ์ฒ˜๋ฆฌ ๊ด€๋ จ ๋ถ€๋ถ„ ์ˆ˜์ •

๐Ÿ“š ๊ธฐํƒ€

  • ์ด๋ฏธ์ง€ ์ฒ˜๋ฆฌ ๊ด€๋ จ ๋ณ€๊ฒฝ ์‚ฌํ•ญ
  1. ์œ ์ €๊ฐ€ ์ด๋ฏธ์ง€๋ฅผ ๋‹ค๋ฅธ ํŒŒ์ผ๋กœ ์ˆ˜์ •ํ•œ ๊ฒฝ์šฐ
    โ†’ image : ๋ณ€๊ฒฝํŒŒ์ผ, isChanged : true
  2. ์œ ์ €๊ฐ€ ์ด๋ฏธ์ง€๋ฅผ ์—†์• ๋„๋ก ์ˆ˜์ •ํ•œ ๊ฒฝ์šฐ(ํ”„๋กœํ•„ ์‚ฌ์ง„ ๋‚ด๋ฆฌ๊ณ  ์‹ถ์„ ๋•Œ)
    โ†’ image : ํŒŒ์ผ ์—†์ด(null), isChanged : true
  3. ์œ ์ €๊ฐ€ ์ด๋ฏธ์ง€๋ฅผ ์ˆ˜์ •ํ•˜์ง€ ์•Š์€ ๊ฒฝ์šฐ
    โ†’ image : ํŒŒ์ผ ์—†์ด(null), isChanged : false

@ChooSeoyeon ChooSeoyeon self-assigned this Jan 14, 2023
@@ -251,9 +253,11 @@ public void updateArtist(Long loginMemberId, ArtistUpdateRequest dto, MultipartF
Member findMember = memberRepository.findById(loginMemberId)
.orElseThrow(() -> new CustomException(ErrorCode.NOT_FOUND_MEMBER));

// ์ž‘๊ฐ€๊ฐ€ ์ด๋ฏธ์ง€๋ฅผ ์—†์• ๋„๋ก ์ˆ˜์ •ํ•œ ๊ฒฝ์šฐ
String imageUrl = null;
Copy link
Contributor

@JunYoung-C JunYoung-C Jan 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ฏธ์ง€ ์‚ญ์ œ๋‚˜ ์ˆ˜์ •์ด ๋ฐœ์ƒํ•˜๋Š” ๊ฒฝ์šฐ์— S3์— ์ €์žฅ๋œ ์ด๋ฏธ์ง€๋“ค๋„ ๊ณ ๋ คํ•ด์ค˜์•ผ ํ•˜์ง€ ์•Š๋‚˜์šฉ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ ๋ถ€๋ถ„์„ ์ € ์—ญ์‹œ ์ƒ๊ฐ์„ ํ•ด๋ดค๋Š”๋ฐ, s3 ์ด๋ฏธ์ง€ ์‚ญ์ œ๋ฅผ ๋„ฃ๋Š”๋‹ค๋ฉด ์ด๋•Œ ์™ธ์— ํšŒ์›ํƒˆํ‡ดํ•  ๋•Œ๋„ s3 ์ด๋ฏธ์ง€ ์‚ญ์ œ๊ฐ€ ํ•„์š”ํ•  ๊ฑฐ ๊ฐ™์•„์„œ ํ•œ ๋ฒˆ์— ๋ธŒ๋žœ์น˜ ํŒŒ์„œ ํ•˜๋Š” ๊ฒŒ ์ข‹์„ ๊ฑฐ ๊ฐ™์•„ ์ผ๋‹จ ์ œ์™ธํ–ˆ์Šต๋‹ˆ๋‹น. ๋˜ ์ผ๋ฐ˜์ ์œผ๋กœ s3์— ์ด๋ฏธ์ง€ ๋„ฃ๋Š”๋‹ค๋ฉด ์‚ญ์ œ๊นŒ์ง€ ํ•˜๋Š”์ง€, ์šฐ๋ฆฌ ํŒ€์€ ์–ด๋–ป๊ฒŒ ํ• ์ง€ ์˜๋…ผ์ด ํ•„์š”ํ•  ๊ฑฐ ๊ฐ™์•„ ์ผ๋‹จ ๋ณด๋ฅ˜ํ–ˆ์Šต๋‹ˆ๋‹ค

# Conflicts:
#	src/main/java/com/sptp/backend/member/repository/Member.java
#	src/main/java/com/sptp/backend/member/service/MemberService.java
#	src/main/java/com/sptp/backend/member/web/dto/request/ArtistUpdateRequest.java
#	src/main/java/com/sptp/backend/member/web/dto/request/MemberUpdateRequest.java
Copy link
Contributor

@Gyubam Gyubam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@ChooSeoyeon ChooSeoyeon merged commit 72a0271 into develop Jan 15, 2023
@ChooSeoyeon ChooSeoyeon deleted the Fix/77-update-member-images branch January 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants