Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/54 chatting #72

Merged
merged 13 commits into from
Jan 14, 2023
Merged

Feat/54 chatting #72

merged 13 commits into from
Jan 14, 2023

Conversation

JunYoung-C
Copy link
Contributor

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ

#54

โœจ ์ž‘์—… ๋‚ด์šฉ

  • websocket ์˜์กด์„ฑ ์ถ”๊ฐ€ ๋ฐ ์„ค์ • ํŒŒ์ผ ๊ตฌํ˜„
  • ์ฑ„ํŒ… ๊ธฐ๋Šฅ ๊ตฌํ˜„
  • message service ๋‹จ์œ„ ํ…Œ์ŠคํŠธ

๐Ÿ“š ๊ธฐํƒ€

  • ์›น์†Œ์ผ“ ์—ฐ๊ฒฐ ํ…Œ์ŠคํŠธ ์„ฑ๊ณต
  • ์ฑ„ํŒ… api๋กœ๋Š” ํ…Œ์ŠคํŠธ๊ฐ€ ์–ด๋ ต๊ธฐ ๋•Œ๋ฌธ์— ํด๋ผ์ด์–ธํŠธ์™€ ์†Œํ†ตํ•˜๋ฉด์„œ ๋™์ž‘ ์—ฌ๋ถ€ ํ™•์ธ ๊ณ„ํš

@JunYoung-C
feat: ํ•„์š” ์—”ํ‹ฐํ‹ฐ ๊ตฌํ˜„
02807db
@JunYoung-C
feat: chatRoom, Message JPARepository ์ƒ์† ์ธํ„ฐํŽ˜์ด์Šค ๊ตฌํ˜„
0779e03
@JunYoung-C
style: ํŒจํ‚ค์ง€๋ช… ๋ณ€๊ฒฝ
5d06fe6
@JunYoung-C
chore: websocket ์„ค์ •
2fbe891
@JunYoung-C
feat: ์ฑ„ํŒ…๋ฐฉ์ด ์กด์žฌํ•˜์ง€ ์•Š๋Š” ๊ฒฝ์šฐ ์˜ˆ์™ธ ์ถ”๊ฐ€
de009ab
@JunYoung-C
feat: ์ฑ„ํŒ… ๊ธฐ๋Šฅ ๊ตฌํ˜„
e12d9c8
@JunYoung-C
test: messageService ๋‹จ์œ„ ํ…Œ์ŠคํŠธ
57f37e5
@JunYoung-C
chore: gitignore์— initDB ๋ฌด์‹œ ์„ค์ •
9f56c6e
@JunYoung-C
feat: ์ฑ„ํŒ… ํ…Œ์ŠคํŠธ์šฉ ๊ธฐ๋Šฅ ๊ตฌํ˜„
d5a8306
@JunYoung-C
Revert "feat: ์ฑ„ํŒ… ํ…Œ์ŠคํŠธ์šฉ ๊ธฐ๋Šฅ ๊ตฌํ˜„"
768cbd4 
This reverts commit d5a8306.
@JunYoung-C JunYoung-C self-assigned this Jan 12, 2023
@JunYoung-C JunYoung-C linked an issue Jan 12, 2023 that may be closed by this pull request
[Feat] ์ฑ„ํŒ… ๊ธฐ๋Šฅ ๊ตฌํ˜„ #54
Closed
3 tasks
ChooSeoyeon
ChooSeoyeon reviewed Jan 12, 2023
View reviewed changes
src/main/java/com/sptp/backend/message/repository/Message.java Outdated
private Member sender;

@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn(name = "artist_id")
Copy link
Member

@ChooSeoyeon ChooSeoyeon Jan 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name์„ chat_room_id๊ฐ€ ์•„๋‹ˆ๋ผ artist_id๋กœ ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์—ฌ?

Gyubam
Gyubam approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@Gyubam Gyubam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ชจ๋‘ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

ChooSeoyeon
ChooSeoyeon approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@ChooSeoyeon ChooSeoyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ •๊นŒ์ง€ ์ „๋ถ€ ํ™•์ธ ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!!

@JunYoung-C JunYoung-C merged commit 09eaf8e into develop Jan 14, 2023
@JunYoung-C JunYoung-C deleted the feat/54-chatting branch January 14, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gyubam Gyubam Gyubam approved these changes

@ChooSeoyeon ChooSeoyeon ChooSeoyeon approved these changes

Assignees

@JunYoung-C JunYoung-C

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] ์ฑ„ํŒ… ๊ธฐ๋Šฅ ๊ตฌํ˜„
3 participants
@JunYoung-C @Gyubam @ChooSeoyeon