Merge pull request #26 from raidiun/duplicate-targets-fix

Duplicate targets fix

lib/make.js

@@ -77,6 +77,7 @@ export function provideBuilder() {
           .split(/[\r\n]{1,2}/)
           .filter(line => /^[a-zA-Z0-9][^$#\/\t=]*:([^=]|$)/.test(line))
           .map(targetLine => targetLine.split(':').shift())
+          .filter( (elem, pos, array) => (array.indexOf(elem) === pos) )
           .map(target => ({
             exec: 'make',
             args: args.concat([ target ]),

spec/Makefile.withduplicates

@@ -0,0 +1,7 @@
+all:
+	@echo "Building all"
+
+duplicated: all
+
+duplicated:
+	@echo "Building duplicated"

spec/build-make-spec.js

@@ -66,6 +66,22 @@ describe('make', () => {
     });
   });
 
+  describe('when makefile contains duplicate targets', () => {
+    beforeEach(() => {
+      fs.writeFileSync(directory + 'Makefile', fs.readFileSync(`${__dirname}/Makefile.withduplicates`));
+    });
+    it('should yield only a single target for each duplicate entry', () => {
+      atom.config.set('build-make.useMake', false); // Not using make to avoid extracting Makefile as pseudotarget
+      waitsForPromise(() => {
+        expect(builder.isEligible(directory)).toBe(true);
+        return Promise.resolve(builder.settings(directory)).then((settings) => {
+          const targetNames = settings.map(s => s.name).sort();
+          expect(targetNames).toEqual([ 'GNU Make: default (no target)', 'GNU Make: all', 'GNU Make: duplicated' ].sort());
+        });
+      });
+    });
+  });
+
   describe('when makefile exists but make can not run', () => {
     const originalPath = process.env.PATH;
     beforeEach(() => {