fix(aowow): fix warnings, switch continue => break (Sarjuuk#4)

AthenaSui · Feb 2, 2020 · 9b1a992 · 9b1a992
1 parent 88669c0
commit 9b1a992
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/includes/community.class.php b/includes/community.class.php
@@ -125,7 +125,7 @@ private static function getSubjects()
                 case TYPE_ENCHANTMENT: $obj = new EnchantmentList($cnd); break;
                 case TYPE_SOUND:       $obj = new SoundList($cnd);       break;
                 case TYPE_ICON:        $obj = new IconList($cnd);        break;
-                default: continue;
+                default: break;
             }
 
             foreach ($obj->iterate() as $id => $__)

diff --git a/includes/utilities.php b/includes/utilities.php
@@ -1021,8 +1021,9 @@ public static function getServerConditions($srcType, $srcGroup = null, $srcEntry
                                 $c['ConditionValue1'] = $zone->getField('id');
                                 break;
                             }
-                            else
-                                continue;
+                            else {
+                                break;
+                            }
                     }
                 case CND_ZONEID:                            // 4
                 case CND_AREAID:                            // 23
@@ -1077,7 +1078,7 @@ public static function getServerConditions($srcType, $srcGroup = null, $srcEntry
                     else if ($c['ConditionValue1'] == 67)   // Horde
                         $c['ConditionValue1'] = 2;
                     else
-                        continue;
+                        break;
             }
 
             $res = [$c['NegativeCondition'] ? -$c['ConditionTypeOrReference'] : $c['ConditionTypeOrReference']];

diff --git a/pages/genericPage.class.php b/pages/genericPage.class.php
@@ -853,7 +853,7 @@ private function applyGlobals()                         // lookup jsGlobals from
                 case TYPE_USER:        $obj = new UserList($cnd);        break;
                 case TYPE_EMOTE:       $obj = new EmoteList($cnd);       break;
                 case TYPE_ENCHANTMENT: $obj = new EnchantmentList($cnd); break;
-                default: continue;
+                default: break;
             }
 
             $this->extendGlobalData($obj->getJSGlobals(GLOBALINFO_SELF));