Fix So That SIA does NOT Write Instance Cert When Local File Backup Used #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlajkim
commented
Nov 15, 2023
mlajkim
commented
Nov 15, 2023
ctyano
reviewed
Nov 15, 2023
mlajkim
changed the title
WindzCUHK
reviewed
Nov 16, 2023
Co-authored-by: Windz <[email protected]> Signed-off-by: Aaron Jeongwoo Kim <[email protected]>
5 tasks
Signed-off-by: Aaron Jeongwoo Kim <[email protected]>
WindzCUHK
approved these changes
Nov 20, 2023
WindzCUHK
deleted the
fix-instance-cert-writing-when-local-backup-file-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When k8s-athenz-sia is used as sidecar, it should not try to write instance cert, when localBackup is used in the red sqaure.
TODOs