Do not merge: Impl inst macro #56
Conversation
| Create a string from `expr`. It tries to output something similar to we type in Julia REPL. | ||
| If `expr` contains `@comment <message>`, it is transformed into `# <message>`. | ||
| """ | ||
| macro inst(expr) |
There was a problem hiding this comment.
I feel the wording inst is a little ambiguous, and 英辞郎 does not list "instruction" as a full form of "inst"..
https://eowf.alc.co.jp/search?q=inst.
Is it bothersome to rename it like instruction?
There was a problem hiding this comment.
How about deparse? That would be a little longer than inst, but I think it describes its behavior correctly.
There was a problem hiding this comment.
Is it bothersome to rename it like instruction?
How about providing both @instruction and @i? The latter macro @i is alias to @instruction, which can be implemented:
module Replay
export @instruction
...
"""
alias to @instruction
"""
const var"@i" = var"@instruction"
...
endUsage:
julia> using Replay
julia> using Replay: @i
julia> @instruction println("Hi")
"println(\"Hi\")"
julia> @i println("Hi")
"println(\"Hi\")"There was a problem hiding this comment.
If I could, I would like to export @i.
There was a problem hiding this comment.
How about providing both
@instructionand@i?
If I could, I would like to export
@i.
I think exporting short variables such as @i is so anti-pattern that other package does not exports and I feel okay:joy:
Do you have any thoughts on deparse?
If this is still long to type, how about defining const var"@d" = var"@deparse"?
There was a problem hiding this comment.
I think exporting short variables such as @i is so anti-pattern that other package does not exports and I feel okay😂
(´・ω・｀) I'm lazy.
Do you have any thoughts on deparse?
If this is still long to type, how about defining const var"@d" = var"@deparse"?
I can't decide right now.
🤔
Let me think about it.
There was a problem hiding this comment.
There was a problem hiding this comment.
I have discussed this with GPT-4. Here's a screenshot of that.
There was a problem hiding this comment.
After googling and pondering for a moment, I found it makes sense to use "deparse". R lang provides a "deparse" function that converts an expression into a character string. I could learn about what "deparse" was. Thank you for your suggestion.
There was a problem hiding this comment.
However, I need to re-create another pull request because of the name of the branch contains "inst". No worry, It's a piece of cake. I will do that.
Co-authored-by: Yuto Horikawa <[email protected]>
No description provided.