Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fish): none-ls opts.sources not being created if it doesn't exist #893

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

Axlefublr
Copy link
Contributor

📑 Description

If opts.sources is not a table (or didn't exist, for that matter), fish linter and formatter didn't get added, they now do.

ℹ Additional Information

Copy link

github-actions bot commented Apr 18, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter mehalter changed the title fix(fish-shell): opts.sources not being created if it doesn't exist fix(fish): none-ls opts.sources not being created if it doesn't exist Apr 18, 2024
@mehalter mehalter merged commit 13b816d into AstroNvim:main Apr 18, 2024
12 checks passed
@Axlefublr Axlefublr deleted the fish-shell branch April 18, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants