Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indent): add indent-rainbowline #808

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

fuchami
Copy link
Contributor

@fuchami fuchami commented Mar 21, 2024

📑 Description

Add rainbow indents plugin.

https://github.com/TheGLander/indent-rainbowline.nvim

ℹ Additional Information

Copy link

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@fuchami fuchami force-pushed the featture/indent-rainbowline branch from 39d164c to 518da44 Compare March 21, 2024 15:35
@Uzaaft
Copy link
Member

Uzaaft commented Mar 21, 2024

#634

@Uzaaft Uzaaft marked this pull request as draft March 21, 2024 17:14
@Uzaaft
Copy link
Member

Uzaaft commented Mar 22, 2024

Feel free to re-open this for v4 to Get it merged ASAP

@fuchami
Copy link
Contributor Author

fuchami commented Mar 24, 2024

I plan to add this feature after v4 is released. thank you.

@Uzaaft Uzaaft changed the base branch from main to v4 March 25, 2024 08:27
@Uzaaft Uzaaft marked this pull request as ready for review March 25, 2024 08:41
@Uzaaft
Copy link
Member

Uzaaft commented Mar 25, 2024

R? @AstroNvim/astrocommunity-maintainers

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion that would allow users to use the opts table for indent-rainbowline to configure the make_opts call

lua/astrocommunity/indent/indent-rainbowline/init.lua Outdated Show resolved Hide resolved
@Uzaaft
Copy link
Member

Uzaaft commented Mar 25, 2024

LGTM now. :) Any last words @mehalter

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzaaft Uzaaft merged commit 2a028c9 into AstroNvim:v4 Mar 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants