Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Fix helm pack misconfiguration #624

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

gl3b4ik
Copy link
Contributor

@gl3b4ik gl3b4ik commented Oct 25, 2023

📑 Description

Fix helm pack misconfiguration causing an error during :TSUpdate

ℹ Additional Information

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owittek
Copy link
Member

owittek commented Oct 25, 2023

Actually you'll have to modify the scope of your PR title/commit to fix(helm)

@gl3b4ik gl3b4ik changed the title fix(pack): Fix helm pack misconfiguration fix(helm): Fix helm pack misconfiguration Oct 25, 2023
@gl3b4ik
Copy link
Contributor Author

gl3b4ik commented Oct 25, 2023

Thanks, I've updated the scope

@owittek owittek merged commit 2601abe into AstroNvim:main Oct 25, 2023
@gl3b4ik gl3b4ik deleted the fix/pack-helm branch October 25, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants