Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add ProtoBuf pack #330

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

20k-ultra
Copy link
Contributor

No description provided.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few changes to make sure this works correctly and a bit more performant

lua/astrocommunity/pack/protobuf/proto.lua Outdated Show resolved Hide resolved
lua/astrocommunity/pack/protobuf/proto.lua Outdated Show resolved Hide resolved
lua/astrocommunity/pack/protobuf/proto.lua Outdated Show resolved Hide resolved
Signed-off-by: Miguel Casqueira <[email protected]>
@20k-ultra 20k-ultra requested a review from mehalter June 29, 2023 20:14
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mehalter mehalter merged commit 7de0680 into AstroNvim:main Jun 29, 2023
mehalter pushed a commit that referenced this pull request Jun 29, 2023
Signed-off-by: Miguel Casqueira <[email protected]>
Co-authored-by: Miguel Casqueira <[email protected]>
Uzaaft pushed a commit that referenced this pull request Jul 1, 2023
Signed-off-by: Miguel Casqueira <[email protected]>
Co-authored-by: Miguel Casqueira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants