Solved minor bugs in load_config.py and imager.py #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion from imager.py when building the dictionary with the cameras
JAAlvarado-Montes
changed the title
load_config.py and imager.py .
wtgee
reviewed
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Anthony,
These are two minor changes, which are:
Adding and
ifstatement to makeload_config.pyto find theperformance_local.yamlindatadirectory where all the config files are located.Removal of an extra indentation from
imager.pywhen building the dictionary with the cameras. This was causing to neglect the properties of any extra imager that the user might put intoperformance_local.yamland just taking the ones from the first camera in the dictionary.Hope this helps a bit to improve
gunagala's functionality.Cheers,
Jaime.