Reduce UnitWeightCost PoV size (#911)

AstarNetwork · Apr 18, 2023 · 8120cd7 · 8120cd7
1 parent 57419ee
commit 8120cd7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/runtime/astar/src/xcm_config.rs b/runtime/astar/src/xcm_config.rs
@@ -129,9 +129,9 @@ pub type XcmOriginToTransactDispatchOrigin = (
 
 parameter_types! {
     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
-    // The default POV size used by Polkadot/Kusama is 64 kB but that breaks backwards compatibility with v2.
-    // A small, but not negligible size of 4 kB is used instead.
-    pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 4 * 1024);
+    // The default POV size used by Polkadot/Kusama was 64 kB but that has been updated here: https://github.com/paritytech/polkadot/pull/7081
+    // We should properly benchmark instructions and get rid of fixed weights.
+    pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 1024);
     pub const MaxInstructions: u32 = 100;
 }
 

diff --git a/runtime/shibuya/src/xcm_config.rs b/runtime/shibuya/src/xcm_config.rs
@@ -126,9 +126,9 @@ pub type XcmOriginToTransactDispatchOrigin = (
 
 parameter_types! {
     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
-    // The default POV size used by Polkadot/Kusama is 64 kB but that breaks backwards compatibility with v2.
-    // A small, but not negligible size of 4 kB is used instead.
-    pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 4 * 1024);
+    // The default POV size used by Polkadot/Kusama was 64 kB but that has been updated here: https://github.com/paritytech/polkadot/pull/7081
+    // We should properly benchmark instructions and get rid of fixed weights.
+    pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 1024);
     pub const MaxInstructions: u32 = 100;
 }
 

diff --git a/runtime/shiden/src/xcm_config.rs b/runtime/shiden/src/xcm_config.rs
@@ -128,9 +128,9 @@ pub type XcmOriginToTransactDispatchOrigin = (
 
 parameter_types! {
     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
-    // The default POV size used by Polkadot/Kusama is 64 kB but that breaks backwards compatibility with v2.
-    // A small, but not negligible size of 4 kB is used instead.
-    pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 4 * 1024);
+    // The default POV size used by Polkadot/Kusama was 64 kB but that has been updated here: https://github.com/paritytech/polkadot/pull/7081
+    // We should properly benchmark instructions and get rid of fixed weights.
+    pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 1024);
     pub const MaxInstructions: u32 = 100;
 }