Set path_style for S3 bucket name with dots

[dlackty]

Recently I updated my fog bundled version and got errors when syncing assets. After digging to the codes, I found several discussions about S3 bucket name with dots included. Ref: fog/fog#2381

Adding :path_style= > true for fog_options when fog_directory contains dots would fix this issue.

This pul request closes #237.

[dallas]

+1 on this

Not sure if this is only AWS specific or if other providers have the same issue and configuration option, but I ended up just doing a simple override of the fog_options method in a config/initializers/asset_sync_overrides.rb file in my Rails app:

module AssetSync
  class Config
    alias_method :original_fog_options, :fog_options

    def fog_options
      options = original_fog_options
      options.merge!(path_style: true) if aws? && fog_directory =~ /\./
      options
    end
  end
end

[dlackty]

@davidjrice any opinion for this pull request? I believed it's helpful for some users.

[josacar]

What are the disadvantages of setting path to true ?

AFAIK, Fog crashes if there's any bucket with dots when trying to list all of them, so adding a guard to check the configured bucket is not a proper solution.

It would be nice to have this fixed by defaulting this or just adding a configuration option.

[dlackty]

Hey @tosbourn, any chance to get this merged? I rebased the master changes, and also passed CI.

[slaskis]

I am unable currently to deploy to heroku because of this issue. I keep getting this error:

Excon::Errors::SocketError: hostname "assets.x.com.s3.amazonaws.com" does not match the server certificate (OpenSSL::SSL::SSLError)

[dlackty]

@slaskis You can temporarily workaround this issue by changing your Gemfile:

gem "asset_sync", github: "dlackty/asset_sync", branch: "path-style"

[slaskis]

Thanks @dlackty! I actually went with another workaround, by setting Fog.credentials = { path_style: true } in my asset_sync.rb initializer.

[dlackty]

closed in favor of #302