Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for external protoc #66

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Allow for external protoc #66

merged 2 commits into from
Aug 12, 2024

Conversation

BonusPlay
Copy link
Contributor

This PR adds partial support for #55 via PROTOC_PATH environment variable.

@Arwalk Arwalk self-requested a review August 12, 2024 21:46
Arwalk
Arwalk requested changes Aug 12, 2024
View reviewed changes
Copy link
Owner

@Arwalk Arwalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a very minor change, this works. Thank you.

build.zig Outdated Show resolved Hide resolved
@BonusPlay @Arwalk
Apply suggestion
2637e9e 
Co-authored-by: Arwalk <[email protected]>
@BonusPlay BonusPlay requested a review from Arwalk August 12, 2024 22:10
@BonusPlay
Copy link
Contributor Author

I've tested it on nixos, which wouldn't work without this PR.

@Arwalk
Copy link
Owner

Arwalk commented Aug 12, 2024

I tested it on the devcontainer too and it worked fine.

@Arwalk
Copy link
Owner

Arwalk commented Aug 12, 2024

Thanks again!

@Arwalk Arwalk merged commit 670f584 into Arwalk:master Aug 12, 2024
5 checks passed
@Arwalk Arwalk mentioned this pull request Aug 13, 2024
Closed
@BonusPlay BonusPlay deleted the fet/custom-protoc branch August 13, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arwalk Arwalk Arwalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BonusPlay @Arwalk