Functioning user system + created schema for game database. #56
Conversation
There was a problem hiding this comment.
It doesn't make sense to run "docker run -d -p 27017:27017 --name=my-mongo mongo:latest".
Configure the dockerfile so that it's done without typing those params, also if my-mongo is the name of the database maybe it would be better something like wichat-mongo
webapp/src/AddUser.js
Outdated
| if (username.length < 3) { | ||
| setError('Username must be at least 3 characters long'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
You should also do validations on server
There was a problem hiding this comment.
I think they only check if the field exists
| } |
There was a problem hiding this comment.
Why do u keep commiting file changes with no real changes
bd/game-model.js
Outdated
| // }); | ||
| // | ||
| // await match.save(); | ||
| // } |
There was a problem hiding this comment.
why do u add this class? And why in this folder?
There was a problem hiding this comment.
Its the data base structure that the game will be using, I created a new folder because nothing else fit
There was a problem hiding this comment.
then add it on a "questions" folder or refactor the users folder so that it's inside bd folder, it wouldn't make sense to have a bd folder while there are other bd-realted services outside that folder (users)
Remember you have to do docker run -d -p 27017:27017 --name=my-mongo mongo:latest to check most of the changes.