Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): 📝 improved "building block view" section with the review comments #47

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix(docs): 📝 improved "building block view" section with the review comments #47

merged 1 commit into from
Mar 3, 2025

Conversation

Diegomcha
Copy link

Changes

Diagrams

  • Added draw.io file to the repository.
  • Removed some unnecesary (implementation) details.
  • Added coloring.
  • Improved naming.
  • Improved organization.

Documentation

  • Updated documentation with the new naming.
  • Improved explanation behind design. Mostly for LLM Service.
  • Improved text style and organization.

@Diegomcha Diegomcha added 📃 type: docs Improvements or additions to documentation 🏛️ cat: design Design related that needs to be decided by the team labels Mar 2, 2025
@Diegomcha Diegomcha self-assigned this Mar 2, 2025
@Diegomcha Diegomcha mentioned this pull request Mar 2, 2025
Open
13 tasks
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Diegomcha Diegomcha mentioned this pull request Mar 2, 2025
Open
@Diegomcha Diegomcha requested a review from UO288992 March 2, 2025 22:37
UO288992
UO288992 approved these changes Mar 3, 2025
View reviewed changes
Copy link

@UO288992 UO288992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is alright.

@UO288992 UO288992 merged commit 416af9b into master Mar 3, 2025
3 checks passed
@UO288992 UO288992 deleted the fix/docs/building-block-view branch March 3, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UO288992 UO288992 UO288992 approved these changes

Assignees

@Diegomcha Diegomcha

Labels
🏛️ cat: design Design related that needs to be decided by the team 📃 type: docs Improvements or additions to documentation
Projects
None yet
Milestone
2. Prototype v0.1 + 2nd deployment
Development

Successfully merging this pull request may close these issues.
2 participants
@Diegomcha @UO288992